Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(models): enhance data binding and encapsulation #42

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Conversation

realybin
Copy link
Member

Refactor properties in CustomInkCanvas, CanvasPage, Progress, and Settings classes to use public properties with [ObservableProperty] attributes. This improves data binding capabilities and encapsulation by replacing private fields with public properties. Additionally, simplify access to the StylusPlugIns collection in CustomInkCanvas.

Refactor properties in CustomInkCanvas, CanvasPage, Progress, and Settings classes to use public properties with [ObservableProperty] attributes. This improves data binding capabilities and encapsulation by replacing private fields with public properties. Additionally, simplify access to the StylusPlugIns collection in CustomInkCanvas.
@realybin realybin self-assigned this Feb 19, 2025
@realybin realybin merged commit 083d6f9 into main Feb 19, 2025
3 checks passed
@realybin realybin deleted the chore branch February 19, 2025 16:12
Copy link

Summary - Code Coverage

Summary
Generated on: 2/19/2025 - 4:13:20 PM
Coverage date: 2/19/2025 - 4:13:17 PM
Parser: Cobertura
Assemblies: 1
Classes: 20
Files: 28
Line coverage: 17.8% (80 of 447)
Covered lines: 80
Uncovered lines: 367
Coverable lines: 447
Total lines: 2122
Branch coverage: 18.7% (15 of 80)
Covered branches: 15
Total branches: 80
Method coverage: Feature is only available for sponsors
Tag: 129_13417161137

Coverage

SketchNow - 17.8%
Name Line Branch
SketchNow 17.8% 18.7%
SketchNow.App 0% 0%
SketchNow.Controls.CustomInkCanvas 0%
SketchNow.Controls.IconWithText 0% 0%
SketchNow.Converters.ColorToBrushConverter 0% 0%
SketchNow.Converters.DivisionMathConverter 0% 0%
SketchNow.Converters.EnumToIndexConverter 0% 0%
SketchNow.Input.StylusPlugIns.CustomStylusPlugin 0%
SketchNow.MainWindow 0% 0%
SketchNow.Models.CanvasPage 32.3% 25%
SketchNow.Models.CanvasPages 35.2%
SketchNow.Models.CursorNotFoundException 0%
SketchNow.Models.CustomCursors 100% 50%
SketchNow.Models.Settings 0%
SketchNow.Properties.Resource 0% 0%
SketchNow.Properties.Settings 35.2%
SketchNow.ViewModels.MainWindowViewModel 65.7% 37.5%
SketchNow.ViewModels.SettingsViewModel 0% 0%
SketchNow.Views.PageNavigationView 0% 0%
SketchNow.Views.SettingsView 0% 0%
SketchNow.Views.ToolBarView 0% 0%

realybin added a commit that referenced this pull request Feb 19, 2025
Refactor properties in CustomInkCanvas, CanvasPage, Progress, and Settings classes to use public properties with [ObservableProperty] attributes. This improves data binding capabilities and encapsulation by replacing private fields with public properties. Additionally, simplify access to the StylusPlugIns collection in CustomInkCanvas.
realybin added a commit that referenced this pull request Feb 19, 2025
Refactor properties in CustomInkCanvas, CanvasPage, Progress, and Settings classes to use public properties with [ObservableProperty] attributes. This improves data binding capabilities and encapsulation by replacing private fields with public properties. Additionally, simplify access to the StylusPlugIns collection in CustomInkCanvas.
realybin added a commit that referenced this pull request Feb 19, 2025
Refactor properties in CustomInkCanvas, CanvasPage, Progress, and Settings classes to use public properties with [ObservableProperty] attributes. This improves data binding capabilities and encapsulation by replacing private fields with public properties. Additionally, simplify access to the StylusPlugIns collection in CustomInkCanvas.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant